[pathspec >= 1.0.0] Update with GitIgnoreSpec.from_lines
#802
+15
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
hswong3i
force-pushed
the
GitIgnoreSpec
branch
from
2531053 to
43bf161
Compare
hswong3i
added a commit
to alvistack/adrienverge-yamllint
that referenced
this pull request
Jan 12, 2026
git clean -xdf
tar zcvf ../python-yamllint_1.37.1.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-yamllint.spec ../python-yamllint_1.37.1-1.spec
cp ../python*-yamllint*1.37.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/adrienverge-yamllint-1.37.1/
rm -rf ../python*-yamllint_1.37.1*.* ../yamllint*1.37.1*.*
See adrienverge#802
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to alvistack/ansible-ansible-lint
that referenced
this pull request
Jan 12, 2026
…nsible#4887)" This reverts commit 0287560. See adrienverge/yamllint#802 Fixes ansible#4887
hswong3i
force-pushed
the
GitIgnoreSpec
branch
from
43bf161 to
32a9528
Compare
hswong3i
added a commit
to alvistack/adrienverge-yamllint
that referenced
this pull request
Jan 12, 2026
git clean -xdf
tar zcvf ../python-yamllint_1.37.1.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-yamllint.spec ../python-yamllint_1.37.1-1.spec
cp ../python*-yamllint*1.37.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/adrienverge-yamllint-1.37.1/
rm -rf ../python*-yamllint_1.37.1*.* ../yamllint*1.37.1*.*
See adrienverge#802
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Owner
|
Thanks @hswong3i! I guess this new code will make yamllint crash if a user still has pathspec < 1.0.0. Could you update Also we could take this suggestion from @cpburnz. Last, could you change the commit title to something more easily understandable? I propose |
To follow Git's implementation, use GitIgnoreSpec.from_lines(...). The change for using this is Git allows including files from excluded directories which directly contradicts the gitignore docs. See adrienverge#800 (comment) Fixes adrienverge#800 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
force-pushed
the
GitIgnoreSpec
branch
from
32a9528 to
2b6b192
Compare
Author
|
@adrienverge as you wish 🫡 |
hswong3i
added a commit
to alvistack/adrienverge-yamllint
that referenced
this pull request
Jan 13, 2026
git clean -xdf
tar zcvf ../python-yamllint_1.37.1.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-yamllint.spec ../python-yamllint_1.37.1-1.spec
cp ../python*-yamllint*1.37.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/adrienverge-yamllint-1.37.1/
rm -rf ../python*-yamllint_1.37.1*.* ../yamllint*1.37.1*.*
See adrienverge#802
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Owner
|
@hswong3i thank you for the update. But it's still not good: To save time and release a fixed version quickly I implemented it (a bit differently), see #803. Thanks again for initiating this 🙏 |
Author
|
@adrienverge thank you for your quick release, your changes looks much elegant than mine ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow Git's implementation, use GitIgnoreSpec.from_lines(...). The change for using this is Git allows including files from excluded directories which directly contradicts the gitignore docs.
See #800 (comment)
Fixes #800